What is ':-!!' in C?

Asked 2023-09-21 08:10:37 View 797,590

I bumped into this strange macro code in /usr/include/linux/kernel.h:

/* Force a compilation error if condition is true, but also produce a
   result (of value 0 and type size_t), so the expression can be used
   e.g. in a structure initializer (or where-ever else comma expressions
   aren't permitted). */
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))

What does :-!! do?


Update: In recent times, the macro has been moved to /usr/include/linux/build_bug.h

  • - Unary minus <br /> ! Logical NOT <br /> inverse not not of the given Integer e so the variable can either be 0 or 1. - anyone
  • git blame tells us that this particular form of static assertion was introduced by Jan Beulich in 8c87df4. Obviously he had good reasons to do it (see the commit message). - anyone
  • Almost goes without saying that the bitfield created is an anonymous one. This is in the same spirit as C++ template meta-programming, i.e. have things happen at compile time that can be checked at compile time. - anyone
  • Wait, I thought the arguments of sizeof are not evaluated. Is that wrong in this case? If so, why? Because it's a macro? - anyone
  • @cpcloud, sizeof does "evaluate" the type, just not the value. Its the type thats invalid in this case. - anyone

Answers

This is, in effect, a way to check whether the expression e can be evaluated to be 0, and if not, to fail the build.

The macro is somewhat misnamed; it should be something more like BUILD_BUG_OR_ZERO, rather than ...ON_ZERO. (There have been occasional discussions about whether this is a confusing name.)

You should read the expression like this:

sizeof(struct { int: -!!(e); }))
  1. (e): Compute expression e.

  2. !!(e): Logically negate twice: 0 if e == 0; otherwise 1.

  3. -!!(e): Numerically negate the expression from step 2: 0 if it was 0; otherwise -1.

  4. struct{int: -!!(0);} --> struct{int: 0;}: If it was zero, then we declare a struct with an anonymous integer bitfield that has width zero. Everything is fine and we proceed as normal.

  5. struct{int: -!!(1);} --> struct{int: -1;}: On the other hand, if it isn't zero, then it will be some negative number. Declaring any bitfield with negative width is a compilation error.

So we'll either wind up with a bitfield that has width 0 in a struct, which is fine, or a bitfield with negative width, which is a compilation error. Then we take sizeof that field, so we get a size_t with the appropriate width (which will be zero in the case where e is zero).


Some people have asked: Why not just use an assert?

keithmo's answer here has a good response:

These macros implement a compile-time test, while assert() is a run-time test.

Exactly right. You don't want to detect problems in your kernel at runtime that could have been caught earlier! It's a critical piece of the operating system. To whatever extent problems can be detected at compile time, so much the better.

Answered   2023-09-21 08:10:37

  • recent variants of C++ or C standards have something like static_assert for related purposes. - anyone
  • @Lundin - #error would require use of 3 lines of code #if/#error/#endif, and would only work for evaluations accessible to the pre-processor. This hack works for any evaluation accessible to the compiler. - anyone
  • The Linux kernel does not use C++, at least not while Linus is still alive. - anyone
  • @Dolda2000: "Boolean expressions in C are defined to always evaluate to zero or one" -- Not exactly. The operators that yield "logically boolean" results (!, <, >, <=, >=, ==, !=, &&, ||) always yield 0 or 1. Other expressions may yield results that may be used as a conditions, but are merely zero or non-zero; for example, isdigit(c), where c is a digit, can yield any non-zero value (which is then treated as true in a condition). - anyone
  • Quick note about the name. It's called ...ON_ZERO because it's a derivative of BUG_ON, a macro that's essentially an assertion. BUG_ON(foo) means "it's a bug if foo is true" (at runtime). Conversely, BUILD_BUG_ON is a static assertion (checked at build time), and finally BUILD_BUG_ON_ZERO is exactly the same, except that the whole thing is an expression equal to (size_t)0, as the comment in the question states. - anyone

The : is a bitfield. As for !!, that is logical double negation and so returns 0 for false or 1 for true. And the - is a minus sign, i.e. arithmetic negation.

It's all just a trick to get the compiler to barf on invalid inputs.

Consider BUILD_BUG_ON_ZERO. When -!!(e) evaluates to a negative value, that produces a compile error. Otherwise -!!(e) evaluates to 0, and a 0 width bitfield has size of 0. And hence the macro evaluates to a size_t with value 0.

The name is weak in my view because the build in fact fails when the input is not zero.

BUILD_BUG_ON_NULL is very similar, but yields a pointer rather than an int.

Answered   2023-09-21 08:10:37

  • is sizeof(struct { int:0; }) strictly conforming? - anyone
  • Why would the result in general be 0? A struct with only an empty bitfield, true, but I don't think that struct with size 0 are allowed. E.g if you'd create an array of that type, the individual array elements still must have different addresses, no? - anyone
  • they actually don't care as as they use GNU extensions, they disable strict aliasing rule and don't consider integer overflows as UB. But I was wondering if this is strictly conforming C. - anyone
  • @ouah regarding unnamed zero length bitfields, see here: stackoverflow.com/questions/4297095/… - anyone
  • @DavidHeffernan actually C allows unamed bit-field of 0 width, but not if there no other named member in the structure. (C99, 6.7.2.1p2) "If the struct-declaration-list contains no named members, the behavior is undefined." So for example sizeof (struct {int a:1; int:0;}) is strictly conforming but sizeof(struct { int:0; }) is not (undefined behavior). - anyone

Some people seem to be confusing these macros with assert().

These macros implement a compile-time test, while assert() is a runtime test.

Update:

As of C11, the _Static_assert() keyword is available to create compile time tests, and should be used unless code is being written for old compilers.

Answered   2023-09-21 08:10:37

Well, I am quite surprised that the alternatives to this syntax have not been mentioned. Another common (but older) mechanism is to call a function that isn't defined and rely on the optimizer to compile-out the function call if your assertion is correct.

#define MY_COMPILETIME_ASSERT(test)              \
    do {                                         \
        extern void you_did_something_bad(void); \
        if (!(test))                             \
            you_did_something_bad(void);         \
    } while (0)

While this mechanism works (as long as optimizations are enabled) it has the downside of not reporting an error until you link, at which time it fails to find the definition for the function you_did_something_bad(). That's why kernel developers starting using tricks like the negative sized bit-field widths and the negative-sized arrays (the later of which stopped breaking builds in GCC 4.4).

In sympathy for the need for compile-time assertions, GCC 4.3 introduced the error function attribute that allows you to extend upon this older concept, but generate a compile-time error with a message of your choosing -- no more cryptic "negative sized array" error messages!

#define MAKE_SURE_THIS_IS_FIVE(number)                          \
    do {                                                        \
        extern void this_isnt_five(void) __attribute__((error(  \
                "I asked for five and you gave me " #number))); \
        if ((number) != 5)                                      \
            this_isnt_five();                                   \
    } while (0)

In fact, as of Linux 3.9, we now have a macro called compiletime_assert which uses this feature and most of the macros in bug.h have been updated accordingly. Still, this macro can't be used as an initializer. However, using by statement expressions (another GCC C-extension), you can!

#define ANY_NUMBER_BUT_FIVE(number)                           \
    ({                                                        \
        typeof(number) n = (number);                          \
        extern void this_number_is_five(void) __attribute__(( \
                error("I told you not to give me a five!"))); \
        if (n == 5)                                           \
            this_number_is_five();                            \
        n;                                                    \
    })

This macro will evaluate its parameter exactly once (in case it has side-effects) and create a compile-time error that says "I told you not to give me a five!" if the expression evaluates to five or is not a compile-time constant.

So why aren't we using this instead of negative-sized bit-fields? Alas, there are currently many restrictions of the use of statement expressions, including their use as constant initializers (for enum constants, bit-field width, etc.) even if the statement expression is completely constant its self (i.e., can be fully evaluated at compile-time and otherwise passes the __builtin_constant_p() test). Further, they cannot be used outside of a function body.

Hopefully, GCC will amend these shortcomings soon and allow constant statement expressions to be used as constant initializers. The challenge here is the language specification defining what is a legal constant expression. C++11 added the constexpr keyword for just this type or thing, but no counterpart exists in C11. While C11 did get static assertions, which will solve part of this problem, it wont solve all of these shortcomings. So I hope that gcc can make a constexpr functionality available as an extension via -std=gnuc99 & -std=gnuc11 or some such and allow its use on statement expressions et. al.

Answered   2023-09-21 08:10:37

  • All of your solutions are NOT alternatives. The comment above the macro is pretty clear "so the expression can be used e.g. in a structure initializer (or where-ever else comma expressions aren't permitted)." The macro returns an expression of type size_t - anyone
  • @Wiz Yes, I am aware of this. Perhaps this was a bit verbose and maybe I need to re-visit my wording, but my point was to explore the various mechanisms for static assertions and show why we're still using negative sized bitfields. In short, if we get a mechanism for constant statement expression, we will have other options open. - anyone
  • Anyway we can't use these macro for a variable. right? error: bit-field ‘<anonymous>’ width not an integer constant Its allowing only constants. So, what's the use? - anyone
  • @Karthik Search the sources of the Linux kernel to see why it's used. - anyone

It's creating a size 0 bitfield if the condition is false, but a size -1 (-!!1) bitfield if the condition is true/non-zero. In the former case, there is no error and the struct is initialized with an int member. In the latter case, there is a compile error (and no such thing as a size -1 bitfield is created, of course).

Answered   2023-09-21 08:10:37

  • Actually it's returning a size_t with value 0 in case the condition is true. - anyone